From 22dd61d919a2b3e04b85b3b1dc6dcd63c988a406 Mon Sep 17 00:00:00 2001
From: Tyler Smalley <tyler.smalley@elastic.co>
Date: Tue, 13 Apr 2021 06:55:50 -0700
Subject: [PATCH] [keystore] Fix openHandle in Jest tests (#96671)

```
[2021-04-07T00:19:27Z] Jest did not exit one second after the test run has completed.
[2021-04-07T00:19:27Z]
[2021-04-07T00:19:27Z] This usually means that there are asynchronous operations that weren't stopped in your tests. Consider running Jest with `--detectOpenHandles` to troubleshoot this issue.
```

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
---
 src/cli_keystore/utils/prompt.js      |  1 +
 src/cli_keystore/utils/prompt.test.js | 36 +++++++++++----------------
 2 files changed, 15 insertions(+), 22 deletions(-)

diff --git a/src/cli_keystore/utils/prompt.js b/src/cli_keystore/utils/prompt.js
index d681f7de2e32cb..195f794db3e6e5 100644
--- a/src/cli_keystore/utils/prompt.js
+++ b/src/cli_keystore/utils/prompt.js
@@ -75,6 +75,7 @@ export function question(question, options = {}) {
     });
 
     rl.question(questionPrompt, (value) => {
+      rl.close();
       resolve(value);
     });
   });
diff --git a/src/cli_keystore/utils/prompt.test.js b/src/cli_keystore/utils/prompt.test.js
index 306d4b2bd66df5..e7ccac4e83e113 100644
--- a/src/cli_keystore/utils/prompt.test.js
+++ b/src/cli_keystore/utils/prompt.test.js
@@ -6,14 +6,11 @@
  * Side Public License, v 1.
  */
 
-import sinon from 'sinon';
 import { PassThrough } from 'stream';
 
 import { confirm, question } from './prompt';
 
 describe('prompt', () => {
-  const sandbox = sinon.createSandbox();
-
   let input;
   let output;
 
@@ -23,30 +20,27 @@ describe('prompt', () => {
   });
 
   afterEach(() => {
-    sandbox.restore();
+    input.end();
+    output.end();
   });
 
   describe('confirm', () => {
     it('prompts for question', async () => {
-      const onData = sandbox.stub(output, 'write');
-
-      confirm('my question', { output });
+      const write = jest.spyOn(output, 'write');
 
-      sinon.assert.calledOnce(onData);
+      process.nextTick(() => input.write('Y\n'));
+      await confirm('my question', { input, output });
 
-      const { args } = onData.getCall(0);
-      expect(args[0]).toEqual('my question [y/N] ');
+      expect(write).toHaveBeenCalledWith('my question [y/N] ');
     });
 
     it('prompts for question with default true', async () => {
-      const onData = sandbox.stub(output, 'write');
-
-      confirm('my question', { output, default: true });
+      const write = jest.spyOn(output, 'write');
 
-      sinon.assert.calledOnce(onData);
+      process.nextTick(() => input.write('Y\n'));
+      await confirm('my question', { input, output, default: true });
 
-      const { args } = onData.getCall(0);
-      expect(args[0]).toEqual('my question [Y/n] ');
+      expect(write).toHaveBeenCalledWith('my question [Y/n] ');
     });
 
     it('defaults to false', async () => {
@@ -87,14 +81,12 @@ describe('prompt', () => {
 
   describe('question', () => {
     it('prompts for question', async () => {
-      const onData = sandbox.stub(output, 'write');
-
-      question('my question', { output });
+      const write = jest.spyOn(output, 'write');
 
-      sinon.assert.calledOnce(onData);
+      process.nextTick(() => input.write('my answer\n'));
+      await question('my question', { input, output });
 
-      const { args } = onData.getCall(0);
-      expect(args[0]).toEqual('my question: ');
+      expect(write).toHaveBeenCalledWith('my question: ');
     });
 
     it('can be answered', async () => {