Unified error reporting in internal/vfs package #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
commented
Jul 25, 2018
urso
commented
- introduce common error type and error codes
- map OS specific errors to vfs common error codes in osfs layer
- introduce common error type and error codes - map OS specific errors to vfs common error codes in osfs layer
ph
approved these changes
Jul 25, 2018
| @@ -0,0 +1,16 @@ | |||
| // Code generated by "stringer -type=Kind -linecomment=true"; DO NOT EDIT. | |||
There was a problem hiding this comment.
I know its a generated file but we might want to have the license header added.
There was a problem hiding this comment.
Done. I updated the go:generate command to run beatsfmt on the generated file. Not perfect, but it's the a good way to ensure I don't drop the license header in another PR, as I tend to run go:generate from time to time.
beatsfmt puts the license header at the top. The side effect of this is that github does not detect the Code generated by comment anymore -> diff will be shown.
With this change the go:generate hint is:
//go:generate stringer -type=Kind -linecomment=true
//go:generate beatsfmt -w kind_string.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.