From eefcefd6f021e9367247a98a29ee37fa9f23818a Mon Sep 17 00:00:00 2001 From: Constance Chen Date: Thu, 16 Sep 2021 15:02:19 -0700 Subject: [PATCH 1/5] Fix regenerating screen reader ID --- src/components/form/super_select/super_select_control.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/form/super_select/super_select_control.tsx b/src/components/form/super_select/super_select_control.tsx index 3278077753d..395591a36af 100644 --- a/src/components/form/super_select/super_select_control.tsx +++ b/src/components/form/super_select/super_select_control.tsx @@ -17,7 +17,7 @@ import classNames from 'classnames'; import { CommonProps } from '../../common'; import { EuiScreenReaderOnly } from '../../accessibility'; -import { htmlIdGenerator } from '../../../services/accessibility'; +import { useGeneratedHtmlId } from '../../../services/accessibility'; import { EuiFormControlLayout, EuiFormControlLayoutProps, @@ -108,7 +108,7 @@ export const EuiSuperSelectControl: ( side: 'right', }; - const screenReaderId = htmlIdGenerator()(); + const screenReaderId = useGeneratedHtmlId(); return ( From d014de5c4297c9ed7fc8233e5fddb2e7fe518f4d Mon Sep 17 00:00:00 2001 From: Constance Chen Date: Thu, 16 Sep 2021 15:07:43 -0700 Subject: [PATCH 2/5] Fix undefined input ID - falls back to a generated ID if passed ID is undefined --- src/components/form/super_select/super_select_control.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/components/form/super_select/super_select_control.tsx b/src/components/form/super_select/super_select_control.tsx index 395591a36af..63c160b7d51 100644 --- a/src/components/form/super_select/super_select_control.tsx +++ b/src/components/form/super_select/super_select_control.tsx @@ -108,13 +108,14 @@ export const EuiSuperSelectControl: ( side: 'right', }; + const inputId = useGeneratedHtmlId({ conditionalId: id }); const screenReaderId = useGeneratedHtmlId(); return ( ( type="button" className={classes} aria-haspopup="true" - aria-labelledby={`${id} ${screenReaderId}`} + aria-labelledby={`${inputId} ${screenReaderId}`} {...rest} > {selectedValue} From b3fcf69ab850ce6eaf6a65eb44285ceb8827766b Mon Sep 17 00:00:00 2001 From: Constance Chen Date: Thu, 16 Sep 2021 15:10:23 -0700 Subject: [PATCH 3/5] Update snapshots to w/ new superselect ID --- .../color_palette_picker.test.tsx.snap | 21 ++++++++++----- .../__snapshots__/super_select.test.tsx.snap | 27 ++++++++++++------- .../super_select_control.test.tsx.snap | 24 +++++++++++------ 3 files changed, 48 insertions(+), 24 deletions(-) diff --git a/src/components/color_picker/color_palette_picker/__snapshots__/color_palette_picker.test.tsx.snap b/src/components/color_picker/color_palette_picker/__snapshots__/color_palette_picker.test.tsx.snap index f1d6766915d..046190e4103 100644 --- a/src/components/color_picker/color_palette_picker/__snapshots__/color_palette_picker.test.tsx.snap +++ b/src/components/color_picker/color_palette_picker/__snapshots__/color_palette_picker.test.tsx.snap @@ -9,6 +9,7 @@ exports[`EuiColorPalettePicker is rendered 1`] = ` >
@@ -27,7 +28,7 @@ exports[`EuiColorPalettePicker is rendered 1`] = `