Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove potentially duplicate EuiPopover id attributes #2667

Merged
merged 3 commits into from
Dec 13, 2019
Merged

Remove potentially duplicate EuiPopover id attributes #2667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
227edbe
remove potentially duplicate id
thompsongl Dec 13, 2019
587a56b
Merge branch 'master' into popover-id
thompsongl Dec 13, 2019
3e7dcf9
CL
thompsongl Dec 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- Fixed `EuiDroppable` not accepting multiple children when using TypeScript ([#2634](https://github.com/elastic/eui/pull/2634))
- Fixed `EuiComboBox` from submitting parent `form` element when selecting options via `Enter` key ([#2642](https://github.com/elastic/eui/pull/2642))
- Fixed `EuiNavDrawer` expand button from losing focus after click ([#2643](https://github.com/elastic/eui/pull/2643))
- Fixed instances of potentially duplicate `EuiPopover` `id` attributes ([#2667](https://github.com/elastic/eui/pull/2667))

## [`17.1.2`](https://github.com/elastic/eui/tree/v17.1.2)

Expand Down
1 change: 0 additions & 1 deletion src/components/suggest/__snapshots__/suggest.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ exports[`EuiSuggest is rendered 1`] = `
>
<div
class="euiPopover euiPopover--anchorDownLeft euiPopover--displayBlock euiInputPopover euiInputPopover--fullWidth"
id="popover"
>
<div
class="euiPopover__anchor"
Expand Down
1 change: 0 additions & 1 deletion src/components/suggest/__snapshots__/suggest_input.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ exports[`EuiSuggestInput is rendered 1`] = `
>
<div
class="euiPopover euiPopover--anchorDownLeft euiPopover--displayBlock euiInputPopover euiInputPopover--fullWidth"
id="popover"
>
<div
class="euiPopover__anchor"
Expand Down
1 change: 0 additions & 1 deletion src/components/suggest/suggest_input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ export class EuiSuggestInput extends Component {
return (
<div className={classes}>
<EuiInputPopover
id="popover"
input={customInput}
isOpen={this.state.isPopoverOpen}
panelPaddingSize="none"
Expand Down
1 change: 0 additions & 1 deletion src/components/table/mobile/__snapshots__/table_sort_mobile.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ exports[`EuiTableSortMobile is rendered 1`] = `
aria-label="aria-label"
class="euiPopover euiPopover--anchorDownRight"
data-test-subj="test subject string"
id="sortPopover"
>
<div
class="euiPopover__anchor"
Expand Down
1 change: 0 additions & 1 deletion src/components/table/mobile/table_sort_mobile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ export class EuiTableSortMobile extends Component<

const mobileSortPopover = (
<EuiPopover
id="sortPopover"
ownFocus
button={mobileSortButton}
isOpen={this.state.isPopoverOpen}
Expand Down