Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiMarkdownEditor] A way to opt out line-breaks plugin #7673

Closed
sakurai-youhei opened this issue Apr 11, 2024 · 0 comments · Fixed by #7676
Closed

[EuiMarkdownEditor] A way to opt out line-breaks plugin #7673

sakurai-youhei opened this issue Apr 11, 2024 · 0 comments · Fixed by #7676

Comments

@sakurai-youhei
Copy link
Member

sakurai-youhei commented Apr 11, 2024

EuiMarkdownEditor defaulted line-breaks plugin to follow the "github.com Flavored" [1] GitHub Flavored Markdown through #5272. In the PR and the source issue #5141, opt-out option was discussed, but it was not implemented at the end.

Now, because of elastic/kibana#180576, I'd like to propose the opt-out option. I will open a PR to make the line-breaks plugin excludable in addition to the tooltip plugin.

An alternative is to filter out unwanted plugins from the ones returned by gettDefaultEuiMarkdownPlugins(), but this requires the filter to be able to identify plugins.

  1. ^ The GitHub Flavored Markdown (hereinafter referred to as the GFM) Spec defines soft line breaks, but the github.com Flavored GFM parses a regular line break as a hard line break. The line-breaks plugin realizes a line-breaking manner in the github.com Flavored GFM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant