Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SSR] Replace htmlIdGenerator usages with useGeneratedHtmlId in all function components #7093

Open
Tracked by #5419
tkajtoch opened this issue Aug 17, 2023 · 2 comments
Labels
good first issue task A task associated with a larger Meta issue tech debt

Comments

@tkajtoch
Copy link
Member

Summary

We currently use both htmlIdGenerator() (44 usages) and useGeneratedHtmlId() (46 usages) in our function components. useGeneratedHtmlId() calls htmlIdGenerator() internally when running on React 17 and lower (see #7078) and neither of these functions is SSR compatible, generating different results on server- and client-side.

Acceptance Criteria

  • All function components should use useGeneratedHtmlId() hook to generate unique identifiers
@berkeli
Copy link

berkeli commented Sep 30, 2023

Hi! I'm new around here. Would it be ok if I take this on?

Copy link

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

@JasonStoltz JasonStoltz added task A task associated with a larger Meta issue and removed stale-issue labels Mar 28, 2024
@github-actions github-actions bot added the Stale label Oct 4, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2024
@cee-chen cee-chen reopened this Oct 14, 2024
@cee-chen cee-chen removed the Stale label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue task A task associated with a larger Meta issue tech debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants