Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort fields panel position misaligned in full screen view #5894

Open
Tracked by #182611
bhavyarm opened this issue May 10, 2022 · 5 comments
Open
Tracked by #182611

Sort fields panel position misaligned in full screen view #5894

bhavyarm opened this issue May 10, 2022 · 5 comments

Comments

@bhavyarm
Copy link
Contributor

Kibana version: 8.3.0 snapshot

Elasticsearch version: 8.3.0 snapshot

Server OS version: darwin_x86_64

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: If you click open sort field ->clear sorting -> pick fields to sort by -> click on full screen , Kibana displays sort fields panel in the middle of screen in discover full screen.

Screen Shot 2022-05-10 at 5 48 37 PM

Plus clicking back on this screen navigates the user away to homescreen instead of discover. ESC works to exit the user from full screen mode.

back_doesnt_work.mp4
@elasticmachine
Copy link
Collaborator

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal transferred this issue from elastic/kibana May 11, 2022
@kertal
Copy link
Member

kertal commented May 11, 2022

Transferring the issue because it's also reproducible in the EUI docs, so it's not Kibana related

@kertal
Copy link
Member

kertal commented May 11, 2022

Plus clicking back on this screen navigates the user away to homescreen instead of discover. ESC works to exit the user from full screen mode.

There's an issue for that #4393

@cee-chen
Copy link
Member

Looks like this behavior is essentially being caused by the nested EuiPopover behavior. Only one outside click on close event is being triggered.

@cchaos, @miukimiu, can we consider another UI/UX alternative to picking a field to sort by? Can we use an accordion instead for instance, or an EuiContextMenuPanel?

@cchaos
Copy link
Contributor

cchaos commented May 11, 2022

Honestly, I wonder if there's a good way to combine both column visibility and sort functionality. I don't know if it's enough just to have an initially de-selected button group to visualize sorting. But here's a VERY quick mock that just combines them both without any other thought. The only problem here would be that sort order would now be dependent on column order (but maybe that's not so bad).

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants