Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cypress] Flaky EuiContextMenuPanel test #5312

Closed
thompsongl opened this issue Oct 21, 2021 · 5 comments · Fixed by #5317
Closed

[Cypress] Flaky EuiContextMenuPanel test #5312

thompsongl opened this issue Oct 21, 2021 · 5 comments · Fixed by #5317
Labels
testing Issues or PRs that only affect tests - will not need changelog entries

Comments

@thompsongl
Copy link
Contributor

Seen this failure a couple times in the last week on different branches:

15:17:57   EuiContextMenuPanel
15:17:57     focus behavior
15:17:57       ✓ is set on the first focusable element by default if there are no items and hasFocus is true (175ms)
15:17:58       ✓ is not set on anything if hasFocus is false
15:18:02     keyboard navigation of items
15:18:02       up/down keys
15:18:02         ✓ focuses the panel by default (139ms)
15:18:03         ✓ down arrow key focuses the first menu item (217ms)
15:18:09         1) subsequently, down arrow key focuses the next menu item
15:18:14         ✓ up arrow key wraps to last menu item (245ms)
15:18:31         ✓ down arrow key wraps to first menu item (272ms)
15:18:34         ✓ subsequently, up arrow key focuses the previous menu item (315ms)
15:18:59       left/right arrow keys
15:18:59         ✓ right arrow key shows next panel with focused item's index (214ms)
15:19:19         ✓ left arrow key shows previous panel (213ms)
15:19:30 
15:19:30 
15:19:30   9 passing (2m)
15:19:30   1 failing
15:19:30 
15:19:30   1) EuiContextMenuPanel
15:19:30        keyboard navigation of items
15:19:30          up/down keys
15:19:30            subsequently, down arrow key focuses the next menu item:
15:19:30      AssertionError: Timed out retrying after 4000ms: expected '<div.euiContextMenuPanel>' to have attribute 'data-test-subj'
@thompsongl thompsongl added the testing Issues or PRs that only affect tests - will not need changelog entries label Oct 21, 2021
@thompsongl thompsongl changed the title [Cypress] Flaky EuiContextMenu test [Cypress] Flaky EuiContextMenuPanel test Oct 21, 2021
@cee-chen
Copy link
Member

Just can't get away from these flakes :sadtrombone:

@cee-chen
Copy link
Member

Ugh, also just saw a failure on left/right arrow keys. Even with retries? That seems super odd, will need to check Cypress configs

13:26:24       left/right arrow keys
13:26:24         ✓ right arrow key shows next panel with focused item's index (188ms)
13:26:32         1) left arrow key shows previous panel

@thompsongl
Copy link
Contributor Author

thompsongl commented Oct 21, 2021

And yet another:

16:57:57     keyboard navigation of items
16:57:57       up/down keys
16:57:57         ✓ focuses the panel by default (152ms)
16:58:02         ✓ down arrow key focuses the first menu item (293ms)
16:58:04         ✓ subsequently, down arrow key focuses the next menu item (311ms)
16:58:04         ✓ up arrow key wraps to last menu item (212ms)
16:58:05         ✓ down arrow key wraps to first menu item (282ms)
16:58:22         1) subsequently, up arrow key focuses the previous menu item

Must be a timing thing with CI because they never fail locally

@cee-chen
Copy link
Member

Good times trying to repro CI failures in local 💀 I'm tempted to just increase the .wait()/retries and see how that does

@cee-chen
Copy link
Member

#5317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Issues or PRs that only affect tests - will not need changelog entries
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants