Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all @elastic/eui imports are merged in the docs' Demo JS tab #5104

Closed
chandlerprall opened this issue Aug 26, 2021 · 0 comments · Fixed by #5533
Closed

Not all @elastic/eui imports are merged in the docs' Demo JS tab #5104

chandlerprall opened this issue Aug 26, 2021 · 0 comments · Fixed by #5533
Assignees
@breehall
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries

Comments

@chandlerprall
Copy link
Contributor

_utils.js does Things™️ that are hard to follow in order to merge multiple EUI imports into one import statement. That doesn't always work, and should be rewritten so the code is followable and works with all our example cases.

Example

First line is a merge (and hoisting?) of the imports for EuiFormRow and htmlIdGenerator, but the multi-line import is untouched.

Screen Shot 2021-08-26 at 1 43 22 PM
@chandlerprall chandlerprall added the documentation Issues or PRs that only affect documentation - will not need changelog entries label Aug 26, 2021
@chandlerprall chandlerprall changed the title Not all @elastic/eui imports are merged in docs Not all @elastic/eui imports are merged in the docs' Demo JS tab Aug 26, 2021
@breehall breehall mentioned this issue Sep 29, 2021
Merged
10 tasks
@breehall breehall self-assigned this Jan 10, 2022
@breehall breehall mentioned this issue Jan 12, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@breehall breehall

Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Docs] Combine All @elastic/eui Imports in the EUI Docs Demo JS Tab breehall/eui
2 participants
@chandlerprall @breehall