-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDataGrid] a11y roles not valid (gridcell without row) #4474
Comments
@chandlerprall how does EUI's automated testing not fail on the same thing? |
Datagrid pages are disabled in the axe check |
For EUI, I can't think of a workaround for getting around this requirement. A For Kibana, at this point, the most practical solution is probably to ignore datagrid classes in the tests. @flash1293 I can help you set that up. |
Looks like react-window is unlikely to fix this (bvaughn/react-window#217) |
Did some exploration on this:
|
Due to virtualization, there are no "row" elements in the data grid anymore.
As the individual cells have a
gridcell
role, this is causing automated a11y tests to fail: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Gridcell_roleI'm not sure about the right solution:
gridcell
role?row
element (even though it's not 100% correct)?cc @myasonik @chandlerprall
The text was updated successfully, but these errors were encountered: