Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiPopover] Allow adjusting buffer for individual window sides #4414

Closed
cchaos opened this issue Jan 5, 2021 · 1 comment · Fixed by #4417
Closed

[EuiPopover] Allow adjusting buffer for individual window sides #4414

cchaos opened this issue Jan 5, 2021 · 1 comment · Fixed by #4417

Comments

@cchaos
Copy link
Contributor

cchaos commented Jan 5, 2021

We currently have an issue where, because we need the popover z-indexes to stay above EuiHeaders, when scrolling the anchor underneath the header, the popover becomes disconnected from the anchor.

image

We've talked about using the container prop but this won't exactly work correctly since the headers are fixed position. The easiest way then is to be able to pass a larger buffer for the top of the window to account for the fixed headers.

Something like:

  /**
   * Minimum distance between the popover and the bounding container;
   * Pass an array of 4 values to adjust each side differently: `[top, right, bottom, left]`
   * Default is 16
   */
  buffer?: number | number[];

Or we could ask for a specific map, but I figured this would map similarly to CSS padding/margin shorthands.

@cchaos
Copy link
Contributor Author

cchaos commented Jan 5, 2021

Potentially related issues: #3845, #4232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant