Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] EuiOverlayMask needs a higher z-index when in fullscreen #3469

Closed
timroes opened this issue May 13, 2020 · 4 comments
Closed

Comments

@timroes
Copy link
Contributor

timroes commented May 13, 2020

The data grid fullscreen currently has a z-index of 8000, while the EuiOverlayMask has a z-index of only 6000. I think the EuiOverlayMask should have a higher z-index than pretty much everything else. Currently if you have actions in a data grid that will open a modal, this won't show when in fullscreen because it's hidden behind the fullscreen mask. I think it would make sense to still see modals even if the data grid is in fullscreen. I am not sure if there is any component where it would make sense, that it has a higher z-index than the EuiOverlayMask.

@cchaos
Copy link
Contributor

cchaos commented May 19, 2020

We are starting to see this problem happen more frequently. Content in portals vs non-portals, elements with EuiOverlayMask as a parent vs sibling, z-index ordering not the same for all instances. (BTW, z-index layer maintenance is really hard when it's declared outside of the consuming app.)

I think most of it extends from the issue that the overlay mask and the content (modal) can be separated. If we add EuiModal as a child to EuiOverlayMask, then the overlay mask gains the same z-index level as the modal. And this would be the same for any component that uses EuiOverlayMask directly.

@timroes
Copy link
Contributor Author

timroes commented May 19, 2020

BTW, z-index layer maintenance is really hard when it's declared outside of the consuming app.

so much seconding this.

Could we potentially at least add a high level zIndex property to the EuiOverlayMask to give consumers an easier way of configuring it? (And maybe add a section in the docs, that you'll most likely need to adjust it to whatever you're putting inside it.)

@cchaos
Copy link
Contributor

cchaos commented May 19, 2020

If you're using <EuiOverlayMask> directly (meaning it isn't added by an EUI component), you can always pass a custom className and supply your own z-index property. Since it is CSS, we try not to do inline styles (since they're hard to override) directly on EUI components and we can't have a prop and then matching styles for every single z-index value possible.

@cchaos cchaos changed the title Give EuiOverlayMask a higher z-index than data grid fullscreen [EuiDataGrid] EuiOverlayMask needs a higher z-index when in fullscreen Sep 20, 2020
@cee-chen
Copy link
Member

I believe this was fixed in #5054

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants