From f1f395f57d3e279686d542c318675b22b515993c Mon Sep 17 00:00:00 2001 From: Dave Snider Date: Wed, 25 Aug 2021 15:18:44 -0400 Subject: [PATCH] Fix screenreader text in DG sort dropdown (#5084) DG dropdown had a problem with i18n text and the close from screen reader. --- CHANGELOG.md | 1 + .../datagrid/column_sorting_draggable.tsx | 16 +++++++++------- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f62135c8089..132e732c356 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ **Bug fixes** - Fixed location of default value of `EuiToolTip`'s `display` prop ([#5066](https://github.com/elastic/eui/pull/5066)) +- Fixed instance of `EuiScreenReader` text being exposed in `EuiDataGrid` sorting menu ([#5084](https://github.com/elastic/eui/pull/5084)) - Fixed default value of `EuiPagination`'s `activePage` to target first page ([#5053](https://github.com/elastic/eui/pull/5053)) **Theme: Amsterdam** diff --git a/src/components/datagrid/column_sorting_draggable.tsx b/src/components/datagrid/column_sorting_draggable.tsx index 02bf66ed1e7..5c3bbd37600 100644 --- a/src/components/datagrid/column_sorting_draggable.tsx +++ b/src/components/datagrid/column_sorting_draggable.tsx @@ -70,13 +70,15 @@ export const EuiDataGridColumnSortingDraggable: FunctionComponent - - {(activeSortLabel: string) =>

{activeSortLabel}

} -
+

+ + {(activeSortLabel: string) => activeSortLabel} + +