From 709470344126effa05c92079c692990537d2dd91 Mon Sep 17 00:00:00 2001 From: David Roberts Date: Wed, 5 Jul 2023 14:28:38 +0100 Subject: [PATCH] Fix put trained model spec (#2169) Built in models like ELSER do not require an inference_config be specified. #2098 adjusted the spec to reflect this in one place, but not in the put trained model API spec. This PR completes the change. --- output/schema/schema.json | 6 +++--- output/typescript/types.ts | 2 +- .../ml/put_trained_model/MlPutTrainedModelRequest.ts | 5 +++-- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/output/schema/schema.json b/output/schema/schema.json index fdf87185c9..913b37066e 100644 --- a/output/schema/schema.json +++ b/output/schema/schema.json @@ -149770,9 +149770,9 @@ } }, { - "description": "The default configuration for inference. This can be either a regression\nor classification configuration. It must match the underlying\ndefinition.trained_model's target_type.", + "description": "The default configuration for inference. This can be either a regression\nor classification configuration. It must match the underlying\ndefinition.trained_model's target_type. For pre-packaged models such as\nELSER the config is not required.", "name": "inference_config", - "required": true, + "required": false, "type": { "kind": "instance_of", "type": { @@ -149890,7 +149890,7 @@ } } ], - "specLocation": "ml/put_trained_model/MlPutTrainedModelRequest.ts#L28-L95" + "specLocation": "ml/put_trained_model/MlPutTrainedModelRequest.ts#L28-L96" }, { "body": { diff --git a/output/typescript/types.ts b/output/typescript/types.ts index 865bc68ba2..0d1e271b8a 100644 --- a/output/typescript/types.ts +++ b/output/typescript/types.ts @@ -14150,7 +14150,7 @@ export interface MlPutTrainedModelRequest extends RequestBase { compressed_definition?: string definition?: MlPutTrainedModelDefinition description?: string - inference_config: MlInferenceConfigCreateContainer + inference_config?: MlInferenceConfigCreateContainer input?: MlPutTrainedModelInput metadata?: any model_type?: MlTrainedModelType diff --git a/specification/ml/put_trained_model/MlPutTrainedModelRequest.ts b/specification/ml/put_trained_model/MlPutTrainedModelRequest.ts index db8eb4bd26..8374b81ccd 100644 --- a/specification/ml/put_trained_model/MlPutTrainedModelRequest.ts +++ b/specification/ml/put_trained_model/MlPutTrainedModelRequest.ts @@ -65,9 +65,10 @@ export interface Request extends RequestBase { /** * The default configuration for inference. This can be either a regression * or classification configuration. It must match the underlying - * definition.trained_model's target_type. + * definition.trained_model's target_type. For pre-packaged models such as + * ELSER the config is not required. */ - inference_config: InferenceConfigCreateContainer + inference_config?: InferenceConfigCreateContainer /** * The input field names for the model definition. */