Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to toggle annotation on/off #299

Open
AlonaNadler opened this issue Aug 6, 2019 · 8 comments
Open

Ability to toggle annotation on/off #299

AlonaNadler opened this issue Aug 6, 2019 · 8 comments
Labels
:annotation Annotation (line, rect, text) related issue enhancement New feature or request :legend Legend related issue

Comments

@AlonaNadler
Copy link

Is your feature request related to a problem? Please describe.
Annotations are very helpful when narrowed down into a specific period of time or filtered on a specific value. When looking at a longer period of time without any filter apply annotations can sometimes overload the chart
It will be helpful to have a switch to turn on/off the annotations from the specific chart when in dashboard/Visualize
image

@AlonaNadler AlonaNadler added enhancement New feature or request :annotation Annotation (line, rect, text) related issue labels Aug 6, 2019
@nickofthyme
Copy link
Collaborator

Might also consider some sort of grouping logic.

@markov00
Copy link
Member

@AlonaNadler this feature seems a bit out of scope of the chart library itself. We are also removing from the chart itself the legend button toggle #268 in favour of let the consumer of the chart implement it's own toggle

@markov00 markov00 mentioned this issue Mar 6, 2020
@markov00 markov00 added the :legend Legend related issue label Mar 26, 2020
@markov00
Copy link
Member

Let's crosslink this other enhancement: #555
Adding the annotation inside the legend will let us to work on that feature

@vinaychandrasekhar
Copy link

Alert annotations are displayed on time series charts in the APM UI, and users will need a way to toggle those annotations on or off. See example screenshot below where user might need to toggle annotations off. Requesting a "bump up" in priority for this issue and fix. Thanks!

image

@nickofthyme
Copy link
Collaborator

@vinaychandrasekhar the main issue, seems to me, is requesting a toggle for all annotations. Is this your expectation too?

Or is your request to toggle each annotation individually? If so what is your expected behavior? If we toggle the from the annotation marker/icon, is the line just toggled or the marker/icon too?

@vinaychandrasekhar
Copy link

@nickofthyme thank you for the questions. cc @katrin-freihofner and @hbharding for their thoughts and input.

the main issue, seems to me, is requesting a toggle for all annotations. Is this your expectation too?

Ideally, I'd imagine each type of annotation having a toggle facility - so, for example, a user might want to toggle the alerts off but might want to retain some other annotation "type" on the charts. Ticket 555 offers a way to control it in that way.

Or is your request to toggle each annotation individually?

Toggling each annotation individually would be too onerous on the user, and could get confusing (for example: if they walk away from the screen after toggling one individual alert but not others, and coming back to that screen later).

@katrin-freihofner
Copy link

I think the annotations should appear similar to the legend:
Kapture 2021-11-30 at 10 48 16

I agree, one legend per annotation type should work.

@nickofthyme
Copy link
Collaborator

Ah got it, so the annotations grouping as a whole is only toggleable via the legend. I think #555 will cover you use case but I added a requirement to enable toggling the annotations on that issue.

I'll keep this open for now and close later if applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:annotation Annotation (line, rect, text) related issue enhancement New feature or request :legend Legend related issue
Projects
None yet
Development

No branches or pull requests

5 participants