Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #9392 to 6.x: Add geo fields to add_host_metadata processor. #9565

Merged
merged 1 commit into from
Dec 17, 2018

Conversation

andrewvc
Copy link
Contributor

Cherry-pick of PR #9392 to 6.x branch. Original message:

** EDIT ** I've left the original issue below the break, but after discussion we added geo fields to the add_host_metadata processor instead of a new one. Original is below


This carries over from the discussion from #8620 .

This adds a new processor that lets users easily add geo fields associated with the host that created the event. You would use it like so:

processors:
  - add_host_geo:
      name: MN HQ
      location: "44.977753, -93.265015"

It's debate-able whether ECS should actually let you put these under perhaps agent.geo. That's something we should discuss here.

One other question here, should we just fold this functionality under add_host_metadata? I believe that probably makes more sense. We agreed in #8620 to make this a separate processor, but with the data nested under host, that makes less sense IMHO.

This lets users add geo data if they have it to the host


(cherry picked from commit c6c4a30)
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I restarted the travis Mac build as it got stuck somehow. If Travis goes green, I'm good to merge.

@andrewvc andrewvc merged commit cd232c8 into elastic:6.x Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants