[Auditbeat] Fix process metricset when not root #9497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/secops |
andrewkroh
reviewed
Dec 11, 2018
webmat
approved these changes
Dec 12, 2018
| ms.log.Warnf("Failed to load process information for PID %d as non-root user. "+ | ||
| "Will suppress further errors of this kind. Error: %v", pid, err) | ||
|
|
||
| // Only warn once at the start of Auditbeat. |
cwurm
force-pushed
the
fix_process_non_root
branch
from
4a4bf94
to
65fc87b
Compare
cwurm
pushed a commit
to cwurm/beats
that referenced
this pull request
Dec 16, 2018
Allow the `process` metricset to run as any user by catching permission errors when trying to read other user's private process information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
processmetricset did not behave very well when being run as a user other than root. It would try to read the private process information of all processes on a system, and output the resulting permission errors.This changes it to catch permission errors to allow running it as any user. It will only report on processes that are readable.
This should also allow re-enabling the unit and system test that were failing in CI.