Add generic async output mode #940
Merged
+864
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
urso
force-pushed
the
enh/async-output-mode
branch
2 times, most recently
from
1b8ac01
to
ce1d5b7
Compare
| // Due to the pull based nature the algorithm will load-balance events by random | ||
| // with workers having less latencies/turn-around times potentially getting more | ||
| // work items then other workers with higher latencies. Thusly the algorithm | ||
| // dynamically adapts to resource availability of server events are forwarded to. |
There was a problem hiding this comment.
Thanks for the highlevel description. Very useful.
|
LGTM. |
- add load balancer working in async mode - add NewAsyncConnection mode generating a single-mode, fail-over mode and load-balanced mode output handler based on async-mode implementation. - rename WithError to WaitOnError + clarify comment
urso
force-pushed
the
enh/async-output-mode
branch
from
7ab74d6
to
ee7e9e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add generic async mode with error handling support on par with other generic output mode for implementation of output requiring/supporting async communications.
Requires #927 to be merged first