Add cache.ttl to add_host_metadata #9359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
requested changes
Dec 4, 2018
| } | ||
|
|
||
| data := host.MapHostInfo(p.info) |
There was a problem hiding this comment.
IIUC the problem was here b/c it never fetched updated info
|
I added |
|
I've added two changelog entries (one under Bugfix, one under Added) - let me know if it's good to merge please. |
ruflin
approved these changes
Dec 4, 2018
cwurm
pushed a commit
to cwurm/beats
that referenced
this pull request
Dec 4, 2018
Fix: Refresh host info when cache expires. Add config parameter `cache.ttl` to control cache expiration (default 5m). (cherry picked from commit 30dfa05)
cwurm
added
v6.6.0
and removed
needs_backport
cwurm
pushed a commit
that referenced
this pull request
Dec 4, 2018
Fix: Refresh host info when cache expires. Add config parameter `cache.ttl` to control cache expiration (default 5m). (cherry picked from commit 30dfa05)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite what is says in the documentation (
NOTE: The host information is refreshed every 5 minutes.) theadd_host_metadataprocessor does not actually ever refresh most of its information (it does the IPs and MACs ifnetinfo.enabled: true, but not the base host info).This PR changes it to call
sysinfo.Host()every time its cache expires.It also adds a
cache.ttlparameter to configure how often that happens. The default stays at5m, and negative values disable caching altogether (most likely at some cost to performance).I did not add the new config parameter to all the
*beat.reference.ymlfiles - I noticed they didn't contain everything (e.g.add_kubernetes_metadata) and I think this parameter is not something most users need to configure. Happy to put it in though if it makes sense.