Convert Filebeat kafka.* to ECS #9297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmat
added
in progress
14 tasks
webmat
force-pushed
the
ecs-kafka-fb
branch
2 times, most recently
from
cafba24
to
f30da0d
Compare
webmat
changed the title
ruflin
reviewed
Dec 20, 2018
| @@ -6,18 +6,18 @@ | |||
| "field": "message", | |||
| "trace_match": true, | |||
| "patterns": [ | |||
| "(?m)%{TIMESTAMP_ISO8601:kafka.log.timestamp}. %{LOGLEVEL:kafka.log.level} +%{JAVALOGMESSAGE:kafka.log.message} \\(%{JAVACLASS:kafka.log.class}\\)$[ \\n]*(?'kafka.log.trace.full'.*)" | |||
| "(?m)%{TIMESTAMP_ISO8601:kafka.log.timestamp}. %{LOGLEVEL:log.level} +%{JAVALOGMESSAGE:message} \\(%{JAVACLASS:kafka.log.class}\\)$[ \\n]*(?'kafka.log.trace.full'.*)" | |||
There was a problem hiding this comment.
Sounds like one day we should have something related to Java class.
@felixbarny Is there a standardised way Java APM agent is storing this info?
ruflin
reviewed
Dec 20, 2018
| @@ -6,9 +6,8 @@ | |||
| "input.type": "log", | |||
| "kafka.log.class": "state.change.logger", | |||
| "kafka.log.component": "Broker id=30", | |||
| "kafka.log.level": "TRACE", | |||
| "kafka.log.message": "Cached leader info PartitionState(controllerEpoch=25, leader=-1, leaderEpoch=15, isr=[10], zkVersion=15, replicas=[10], offlineReplicas=[10]) for partition __consumer_offsets-16 in response to UpdateMetadata request sent by controller 20 epoch 25 with correlation id 8", | |||
| "log.level": "TRACE", | |||
There was a problem hiding this comment.
Looks like a log level we haven't really used yet. No change needed.
ruflin
approved these changes
Dec 20, 2018
webmat
force-pushed
the
ecs-kafka-fb
branch
2 times, most recently
from
baf3209
to
0b77277
Compare
added 4 commits
December 20, 2018 14:26
- kafka.log.level => log.level - kafka.log.message => message
The pipeline ends with remove `remove field kafka.log.timestamp`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caveats
message, and cleaned up messagein kafka.log.message. Keeping original message will be addressed elsewhere,
and this PR now replaces
messagewith the cleaned up message.Renames
TODO
Noticed
kafka.log.trace.full