Add cursor_seek_fallback option #9234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
added
review
needs_backport
ph
suggested changes
Nov 26, 2018
There was a problem hiding this comment.
@kvch golang code LGTM, can you add a documentation entry about that new setting in the [doc](https://github.com/elastic/beats/blob/master/journalbeat/docs/config-options.asciidoc?
CI is also failing on make check
| @@ -2,7 +2,10 @@ | |||
| journalbeat.inputs: | |||
| - paths: [{{ journal_path }}] | |||
| seek: {{ seek_method }} | |||
| matches: [{{ matches }}] | |||
| {% if seek_method == 'cursor' %} | |||
There was a problem hiding this comment.
For limiting surprises instead of checking for seek_method == "cursor" it would be more flexible and explicit to use if cursor_seek_fallback
There was a problem hiding this comment.
I wrote if cursor_seek_fallback and seek_method == 'cursor' to not to add that line when some other seek method is configured.
There was a problem hiding this comment.
What I meant by that is when you write your tests you want a direct relationship to what you define in the dictionary in python and what will be generated in the YAML config. When you use if cursor_seek_fallback and seek_method == 'cursor' you make the assumption that I might have made a mistake by configuring seek_method to another value than "cursor".
The problem by doing that is I won't know it without either looking at the YAML or in the output log.
urso
reviewed
Nov 26, 2018
| # journalbeat can seek to the position defined in cursor_seek_fallback. | ||
| "Seeking method set to cursor, but no state is saved for reader. Starting to read from the end", | ||
| # message can be read from test journal | ||
| "\"message\": \"thinkpad_acpi: please report the conditions when this event happened to ibm-acpi-devel@lists.sourceforge.net\"", |
There was a problem hiding this comment.
Where have you got the test message from :)
kvch
force-pushed
the
feature-journalbeat-cursor-fallback-option
branch
from
893a285
to
b87e37b
Compare
kvch
changed the title
urso
approved these changes
Nov 27, 2018
ph
approved these changes
Nov 27, 2018
|
Failing tests are unrelated. |
kvch
added a commit
to kvch/beats
that referenced
this pull request
Nov 28, 2018
New option is introduced to configure the fallback method of seek mode `"cursor"`. The option is named `cursor_seek_fallback`. The name is taken from the community Journalbeat: https://github.com/mheese/journalbeat/blob/master/config/journalbeat.yml#L3 By default it seeks to the beginning as before. But from now on it is possible to configure it to start reading from the end of the journal. (cherry picked from commit f3cbc0a)
kvch
added
v6.6.0
and removed
needs_backport
kvch
added a commit
to kvch/beats
that referenced
this pull request
Nov 28, 2018
New option is introduced to configure the fallback method of seek mode `"cursor"`. The option is named `cursor_seek_fallback`. The name is taken from the community Journalbeat: https://github.com/mheese/journalbeat/blob/master/config/journalbeat.yml#L3 By default it seeks to the beginning as before. But from now on it is possible to configure it to start reading from the end of the journal. (cherry picked from commit f3cbc0a)
kvch
added a commit
that referenced
this pull request
Nov 29, 2018
New option is introduced to configure the fallback method of seek mode `"cursor"`. The option is named `cursor_seek_fallback`. The name is taken from the community Journalbeat: https://github.com/mheese/journalbeat/blob/master/config/journalbeat.yml#L3 By default it seeks to the beginning as before. But from now on it is possible to configure it to start reading from the end of the journal. (cherry picked from commit f3cbc0a)
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
New option is introduced to configure the fallback method of seek mode `"cursor"`. The option is named `cursor_seek_fallback`. The name is taken from the community Journalbeat: https://github.com/mheese/journalbeat/blob/master/config/journalbeat.yml#L3 By default it seeks to the beginning as before. But from now on it is possible to configure it to start reading from the end of the journal.
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
New option is introduced to configure the fallback method of seek mode `"cursor"`. The option is named `cursor_seek_fallback`. The name is taken from the community Journalbeat: https://github.com/mheese/journalbeat/blob/master/config/journalbeat.yml#L3 By default it seeks to the beginning as before. But from now on it is possible to configure it to start reading from the end of the journal. (cherry picked from commit f3cbc0a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New option is introduced to configure the fallback method of seek mode
"cursor". The option is namedcursor_seek_fallback. The name is taken from the community Journalbeat: https://github.com/mheese/journalbeat/blob/master/config/journalbeat.yml#L3By default it seeks to the beginning as before. But from now on it is possible to configure it to start reading from the end of the journal.