Cherry-pick #9069 to 6.x: Propagate Sync error when running SafeFileRotate #9141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it was possible SafeFileRotate encountered an error without propagating it, because the return value of os.Sync was not utilized. From now on the errors from Sync are propagated. (cherry picked from commit 93eb92a)
|
Failing tests are unrelated. |
exekias
approved these changes
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #9069 to 6.x branch. Original message:
Previously, it was possible
SafeFileRotateencountered an error without propagating it, because the return value ofos.Syncwas not utilized.From now on the errors from
Syncare propagated.