No condition required for autodiscover. Bool condition added #8897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewvc
added
enhancement
in progress
andrewvc
added
review
and removed
in progress
This patch allows you to use the autodiscover without any filtering via conditions. I initially considered doing this by making the condition nullable via a pointer, but then decided that boolean conditions can be convenient (and are as fast for this purpose) and might be generally nice for the conditions language. So, instead, this accomplishes the same by inserting an always true condition if the conditions config option is omitted.
exekias
reviewed
Nov 5, 2018
| return nil, err | ||
| condMap := &ConditionMap{Configs: c.Configs} | ||
|
|
||
| if c.ConditionConfig == nil { |
There was a problem hiding this comment.
You could be doing this nil check here:
conditions package
ruflin
reviewed
Nov 6, 2018
|
This would fix #7310 |
|
Thinking about this further, I think @exekias is right that we should just have an empty condition. In most expression languages you do have a boolean literal, but this isn't a normal language. The number of use cases for that are small. Given that, I'll open a new PR soon that checks for a nullable pointer and assumes that is always 'true'. |
|
Closing in favor of #9029 which just makes conditions in autodiscover nullable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows you to use the autodiscover without any filtering via conditions. Today, if you want to disable the conditions syntax on autodiscover you have to makeup a weird condition that does nothing (like checking for the hostname, if it's always there).
I initially considered doing this by making the condition nullable via a pointer, but
then decided that boolean conditions can be convenient (and are as fast for this purpose)
and might be generally nice for the conditions language.
So, instead, this accomplishes the same by inserting an always true condition if the
conditions config option is omitted.