Filebeat: Elasticsearch server fileset: Add paths for Mac OSX and Windows

[ycombinator]

Resolves #8887.

This PR makes the elasticsearch/server fileset paths for Mac OSX and Windows consistent with other filesets' paths in the module. This also means that a user can now install Filebeat, enable the Elasticsearch module, and run Filebeat without any errors.

[ruflin]

LGTM. Should we add a changelog for this?

For the OS X default path: Is that when installed with brew?

[ycombinator]

Should we add a changelog for this?

Sure, I'll add to this PR.

For the OS X default path: Is that when installed with brew?

TBH, I don't know. It was the same path used in other elasticsearch filesets so I just made this fileset consistent with those ones.

[ycombinator]

jenkins, test this

[ruflin]

@ycombinator Can you follow up on this one after merging and see if the path is correct for OS X?

[ycombinator]

Hey @radoondas In this PR I've set the Mac OSX logfile paths for the elasticsearch/server fileset to /usr/local/elasticsearch/*.log. I got that base directory (/usr/local/elasticsearch/) from other filesets in the elasticsearch module.

Looking at the commits on those other filesets, I see that you set the logfile paths on those. @ruflin and I were wondering how you chose /usr/local/elasticsearch/ as the base directory path for Elasticsearch logs on Mac OSX. Is this the path that Homebrew installs in or something else?

[radoondas]

@ycombinator Thanks for fixing this. It looks like I did not check paths in modules's metricset.