Cherry-pick #8292 to 6.x: Added 'query' parameter to metricbeats global configuration #8463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
reviewed
Sep 27, 2018
CHANGELOG.asciidoc
Outdated
| @@ -113,6 +113,8 @@ https://github.com/elastic/beats/compare/v6.4.0...6.x[Check the HEAD diff] | |||
| - Added 'died' PID state to process_system metricset on system module {pull}8275[8275] | |||
| - Add `metrics` metricset to MongoDB module. {pull}7611[7611] | |||
| - Added `ccr` metricset to Elasticsearch module. {pull}8335[8335] | |||
| - Added support for query params in configuration {issue}8286[8286] {pull}8292[8292] | |||
| - Support for Kafka 2.0.0 {pull}8399[8399] | |||
There was a problem hiding this comment.
This line is not related to this change.
There was a problem hiding this comment.
It was the conflict on the first PR. Should I remove it?
There was a problem hiding this comment.
Yes, this PR should only contain the changes intended to be backported.
jsoriano
approved these changes
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #8292 to 6.x branch. Original message:
Initial PR on
mbpackage which fixes issue #8286 but I guess it will be better to implement in the HTTP helper. The thing is that the URI parsing of a metricbeat occurs in thembpackage so to implement it outside of it could lead to ugly-and-not-so-predictable codeI've tested in local successfully but I haven't found a test that already covers
Build()method.Ideas welcome :)