Switch to different UUID lib due to non-random generated UUIDs #8458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
added
review
libbeat
needs_backport
|
|
|
Seems like |
kvch
changed the title
ph
approved these changes
Sep 27, 2018
CHANGELOG.asciidoc
Outdated
| @@ -45,6 +45,7 @@ https://github.com/elastic/beats/compare/v6.4.0...master[Check the HEAD diff] | |||
| - Add backoff support to x-pack monitoring outputs. {issue}7966[7966] | |||
| - Fix a race condition with the `add_host_metadata` and the event serialization. {pull}8223[8223] | |||
| - Enforce that data used by k8s or docker doesn't use any reference. {pull}8240[8240] | |||
| - Switch to different UUID lib: github.com/gofrs/uuid. {pull}8485[8485] | |||
There was a problem hiding this comment.
Can we insert why we switch probably adding a word about collision in the old library.
kvch
changed the title
kvch
force-pushed
the
switch-uuid-libs
branch
from
5bf4cbe
to
5ec6d4e
Compare
|
Updated changelog entry and rebased on top of #8469 |
ph
approved these changes
Sep 27, 2018
|
Make check fails on CI |
andrewkroh
reviewed
Sep 28, 2018
| @@ -35,7 +36,11 @@ func init() { | |||
| beatMetrics = monitoring.Default.NewRegistry("beat") | |||
| monitoring.NewFunc(beatMetrics, "info", reportInfo, monitoring.Report) | |||
|
|
|||
| ephemeralID = uuid.NewV4() | |||
| var err error | |||
| ephemeralID, err = uuid.NewV4() | |||
There was a problem hiding this comment.
What's the impact to monitoring if the ephemeral ID is Nil?
There was a problem hiding this comment.
The beat won't show up in some visualizations.
| key = uuid.NewV4() | ||
| key, err := uuid.NewV4() | ||
| if err != nil { | ||
| return uuid.UUID{}, err |
There was a problem hiding this comment.
Use uuid.Nil here? It's the same but slightly more clear.
|
I just merged #8559, which adds a new use of this lib in |
This was referenced Oct 4, 2018
* no longer maintained * contains critical bug which leads to generating similar and same UUIDs
|
This should be ready for the next round of review. |
Merged
1 task
kvch
added
v6.5.0
and removed
needs_backport
kvch
added a commit
to kvch/beats
that referenced
this pull request
Oct 18, 2018
…ic#8458) The previously used `github.com/satori/go-uuid` lib has a critical bug and it is no longer maintained. The community moved to an active fork of this existing lib named `github.com/gofrs/uuid`. I haven't seen other UUID libs worth mentioning apart from this. Changes compared to the previous dependency: * `uuid.NewV4` returns an error if the function call failed * `uuid.Equal` is deprecated and removed. The Way is to use `==` instead. Closes elastic#8077 (cherry picked from commit 554ddcd)
kvch
added a commit
that referenced
this pull request
Oct 18, 2018
#8640) The previously used `github.com/satori/go-uuid` lib has a critical bug and it is no longer maintained. The community moved to an active fork of this existing lib named `github.com/gofrs/uuid`. I haven't seen other UUID libs worth mentioning apart from this. Changes compared to the previous dependency: * `uuid.NewV4` returns an error if the function call failed * `uuid.Equal` is deprecated and removed. The Way is to use `==` instead. Closes #8077 (cherry picked from commit 554ddcd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previously used
github.com/satori/go-uuidlib has a critical bug and it is no longer maintained. The community moved to an active fork of this existing lib namedgithub.com/gofrs/uuid. I haven't seen other UUID libs worth mentioning apart from this.Changes compared to the previous dependency:
uuid.NewV4returns an error if the function call faileduuid.Equalis deprecated and removed. The Way is to use==instead.TODO
github.com/elastic/go-ucfgCloses #8077