Add jvm9 logging format to GC fileset of ES module #7390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After `date` processor has been added @timestamp is of type date so the its formatting will be different
ruflin
reviewed
Jun 21, 2018
| @@ -14,3 +14,11 @@ | |||
| type: float | |||
| description: > | |||
| Time took to stop threads seconds. | |||
| - name: pid | |||
There was a problem hiding this comment.
I wonder if we should change this to process.pid in a follow up PR? https://github.com/elastic/ecs#process
There was a problem hiding this comment.
sounds good. tags field seems like a good candidate too.
There was a problem hiding this comment.
initially I thought to rename elasticsearch.gc.tags to tags but now I don't think it's a good idea. Tags are more generic while elasticsearch.gc.tags are GC specific fields with values of safepoint, gc, heap, age. I will rename PID field only.
There was a problem hiding this comment.
++ on what you stated about the tags. We had very similar discussions in other places like docker and often these tags are service specific so don't belong in the global ones.
20 tasks
immon
added a commit
to immon/beats
that referenced
this pull request
Jun 22, 2018
follow-up of elastic#7390
ruflin
pushed a commit
that referenced
this pull request
Jun 25, 2018
* rename PID field name to match ECS scheme * Add darwin and windows paths to the log files * simplify windows path pattern follow-up of #7390
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.