Set default metricsets for rabbitmq module #6743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
ruflin
reviewed
Apr 3, 2018
| period: 10s | ||
| hosts: ["localhost:15672"] | ||
|
|
||
| username: guest |
There was a problem hiding this comment.
Do we have a default username and password? If not we should comment these two out.
There was a problem hiding this comment.
Commented out, they are indeed not set by default.
ruflin
reviewed
Apr 3, 2018
| @@ -21,12 +22,7 @@ in <<configuration-metricbeat>>. Here is an example configuration: | |||
| ---- | |||
| metricbeat.modules: | |||
| - module: rabbitmq | |||
| metricsets: ["node", "queue", "connection"] | |||
There was a problem hiding this comment.
Should we just make the other 2 metricsets beta?
Warning messages about metricsets being experimental changed to beta to match documentation.
jsoriano
force-pushed
the
rabbitmq-default-metricset
branch
from
c0b4596
to
5d9452c
Compare
jsoriano
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6668
Warnings reporting modules as experimental have been changed to beta, so all metricsets are set as default.