Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes autodiscover's appender configuration example #6720

Merged
merged 1 commit into from
Apr 3, 2018

Conversation

ph
Copy link
Contributor

@ph ph commented Mar 30, 2018

The current YAML representation in the configuration is invalid, this
PR fixes the alignment.

Reported in https://discuss.elastic.co/t/filebeat-autodiscovery-appenders/126009

@exekias @vjsamuel I think this should be correct format from what I see in the code?

The current `YAML` representation in the configuration is invalid, this
PR fixes the alignment.
@ph ph requested a review from exekias March 30, 2018 13:33
@ph ph added the needs_backport PR is waiting to be backported to other branches. label Mar 30, 2018
@ph
Copy link
Contributor Author

ph commented Mar 30, 2018

Orignal PR with the documentation: #6469

@ph
Copy link
Contributor Author

ph commented Mar 30, 2018

added @vjsamuel to the description :)

@ruflin ruflin merged commit fbc61e8 into elastic:master Apr 3, 2018
@ruflin
Copy link
Member

ruflin commented Apr 3, 2018

@vjsamuel Why do we have the CoditionConfig in the AppenderConfig struct

ConditionConfig *processors.ConditionConfig `config:"condition"`

an also in the appender config:

ConditionConfig *processors.ConditionConfig `config:"condition"`

Do we need both?

@ph ph removed needs_backport PR is waiting to be backported to other branches. review labels Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants