Set default metricset for uwsgi module #6688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
jsoriano
force-pushed
the
uwsgi-default-metricset
branch
from
8c01da6
to
8fb8a53
Compare
ruflin
reviewed
Mar 29, 2018
| @@ -1,4 +1 @@ | |||
| - module: uwsgi | |||
| metricsets: ["status"] | |||
| period: 10s | |||
| hosts: ["tcp://127.0.0.1:9191"] | |||
There was a problem hiding this comment.
did you remove the host intentionally? Our config.yml gets shorter and short. There could be arguments to also remove the hosts part. @andrewkroh ?
There was a problem hiding this comment.
I was thinking that this was the default, I was wrong :) I'll readd the host entry.
There was a problem hiding this comment.
Well, in the documentation it says this is the default, but I cannot find it in the code, I'm going to take a look to this so doc and code are aligned.
There was a problem hiding this comment.
I have readded the host entry, and rephrashed doc to mention tcp://127.0.0.1:9191 as example instead of default.
jsoriano
force-pushed
the
uwsgi-default-metricset
branch
from
8fb8a53
to
77fdb25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6668