Set namespace as default metricset in Aerospike module #6669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ruflin
commented
Mar 27, 2018
ruflin
commented
- Remove metricset config from short config
- Document default
32 tasks
ruflin
commented
Mar 27, 2018
| @@ -25,7 +25,6 @@ in <<configuration-metricbeat>>. Here is an example configuration: | |||
| ---- | |||
| metricbeat.modules: | |||
| - module: aerospike | |||
| metricsets: ["namespace"] | |||
There was a problem hiding this comment.
I removed the metricset config from the short config to make it even shorter, but not sure yet if this is a good idea.
There was a problem hiding this comment.
Working on further modules I realised we should make a decision for each module. If there is only 1 metricset for example, we don't need it. Updated PR accordingly.
ruflin
force-pushed
the
aerospike-default
branch
from
25d17f2
to
3484d67
Compare
jsoriano
approved these changes
Mar 27, 2018
andrewkroh
reviewed
Mar 27, 2018
| @@ -25,8 +25,6 @@ in <<configuration-metricbeat>>. Here is an example configuration: | |||
| ---- | |||
| metricbeat.modules: | |||
| - module: aerospike | |||
| metricsets: ["namespace"] | |||
| enabled: false | |||
| period: 10s | |||
There was a problem hiding this comment.
Personally I'd like to see period: 10s removed too. And only show this in the reference config.
There was a problem hiding this comment.
SGTM. @jsoriano WDYT, should we clean up the period too (in case we don't set a different default)? Will make things even shorter.
* Remove metricset config from short config * Document default
ruflin
force-pushed
the
aerospike-default
branch
from
3484d67
to
f9b66c8
Compare
|
New version pushed with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.