Make collector default prometheus metricset
#6636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
force-pushed
the
prometheus-default-metricset
branch
from
7224f01
to
3c1aa7b
Compare
exekias
force-pushed
the
prometheus-default-metricset
branch
from
3c1aa7b
to
20103d0
Compare
ruflin
reviewed
Mar 23, 2018
| if err := mb.Registry.AddMetricSet("prometheus", "collector", New, hostParser); err != nil { | ||
| panic(err) | ||
| } | ||
| mb.Registry.MustAddMetricSet("prometheus", "collector", New, |
There was a problem hiding this comment.
We should have a mention of this in the docs.
@andrewkroh Thanks for this feature. We should probably make use of it in some other modules.
|
@exekias I think the failing tests could be related (docker labels). |
jsoriano
approved these changes
Mar 23, 2018
andrewkroh
approved these changes
Mar 23, 2018
Signed-off-by: Carlos Pérez-Aradros Herce <carlos@elastic.co>
exekias
force-pushed
the
prometheus-default-metricset
branch
from
20103d0
to
1efb29b
Compare
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes prometheus collector the default metricset, so there is no need to declare it when using it by hand or in autodiscover: