[6.x] Configuration to allow users to retry loading dashboards (#6560) #6602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configuration to allow users to retry loading dashboards if Kibana is not reachable, instead of exiting right away.
houndci-bot
reviewed
Mar 20, 2018
| @@ -21,13 +23,13 @@ type KibanaLoader struct { | |||
| msgOutputter MessageOutputter | |||
| } | |||
|
|
|||
| func NewKibanaLoader(cfg *common.Config, dashboardsConfig *Config, hostname string, msgOutputter MessageOutputter) (*KibanaLoader, error) { | |||
| func NewKibanaLoader(ctx context.Context, cfg *common.Config, dashboardsConfig *Config, hostname string, msgOutputter MessageOutputter) (*KibanaLoader, error) { | |||
There was a problem hiding this comment.
exported function NewKibanaLoader should have comment or be unexported
| Retry *Retry `config:"retry"` | ||
| } | ||
|
|
||
| type Retry struct { |
There was a problem hiding this comment.
exported type Retry should have comment or be unexported
|
@ruflin i would be great if you could merge this after ci run, so we can backport it also in apm-server and do some tests with 6.x even before FF |
|
@jalvz Thanks for the backport. We do bulk backports so no need to manually backport. I will check that we can make one other bulk backport soonish so you can test this. Going to close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 6.x: