Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move MongoDB module to GA #6554

Merged
merged 2 commits into from
Mar 15, 2018
Merged

Move MongoDB module to GA #6554

merged 2 commits into from
Mar 15, 2018

Conversation

exekias
Copy link
Contributor

@exekias exekias commented Mar 15, 2018

No description provided.

ruflin
ruflin approved these changes Mar 15, 2018
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@exekias Did you have chance to check if the fields follow our naming conventions?

@exekias
Copy link
Contributor Author

exekias commented Mar 15, 2018

I checked current fields, we don't always have the same opinion there so a second look would be ok if you want, I'm happy to change some if you point them out 😇

@ruflin
Copy link
Member

ruflin commented Mar 15, 2018

@exekias If you checked and you're happy, I'm happy ;-)

@ruflin ruflin merged commit 4aebadc into elastic:master Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
Metricbeat Metricbeat module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@exekias @ruflin