Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Golang 1.9.4 #6326

Merged
merged 2 commits into from
Feb 13, 2018
Merged

Update to Golang 1.9.4 #6326

merged 2 commits into from
Feb 13, 2018

Commits on Feb 12, 2018

  1. Update to Golang 1.9.4 

    Keep up with the latest version of Golang. Version prior to 1.9.4 are
affected by security issues on build. `go get` could have been used to do unwanted
code execution[1] CVE-2018-6574 during build.

The changes in golang now enforce more restrictive pragma declaration
when linking and compiling.

This commits, disable crosscompiling under solaris which requires an
update on the standard library.

```
../vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.go:13:3: //go:cgo_import_dynamic libc_pipe pipe "libc.so" only allowed in cgo-generated code
../vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.go:14:3: //go:cgo_import_dynamic libc_getsockname getsockname "libsocket.so" only allowed in cgo-generated code
```

We also update popsutil, thag was incorrectly defining an ldflags in a
previous release making the build fails under the new restriction.

[1] golang/go#23672
    @ph
    ph committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    5fc93c6 View commit details
    Browse the repository at this point in the history

  2. update vendor correctly

    @ph
    ph committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    00cadd7 View commit details
    Browse the repository at this point in the history