Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the url field of heartbeat aggregatable. #6263

Closed
wants to merge 2 commits into from
Closed

Make the url field of heartbeat aggregatable. #6263

wants to merge 2 commits into from

Conversation

perjahn
Copy link
Contributor

@perjahn perjahn commented Feb 2, 2018

No description provided.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@andrewkroh
Copy link
Member

Some people may be relying on the fact that the URL is analyzed for their searching. I suggest we make this a multi-field so that there are http.url (text) and http.url.keyword (keyword) fields. Here's an example.

- name: path
type: text
description: The path to the file.
multi_fields:
- name: raw
type: keyword
description: >
The path to the file. This is a non-analyzed field that is useful
for aggregations.

@perjahn
Copy link
Contributor Author

perjahn commented Feb 2, 2018

Sure. Try 2.

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you please add an entry to the CHANGELOG.asciidoc file.

@perjahn
Copy link
Contributor Author

perjahn commented Feb 2, 2018

Should be done. (there was some strange character on line 2391 in the asciidoc file, Cache: optional...)

@ruflin
Copy link
Member

ruflin commented Feb 3, 2018

@perjahn Can you run make update in the heartbeat directory to update the auto generated files?

@perjahn
Copy link
Contributor Author

perjahn commented Feb 5, 2018

Sorry, having some problems with my environment.

@ruflin
Copy link
Member

ruflin commented Feb 6, 2018

Let us know if we can help.

@kvch
Copy link
Contributor

kvch commented Feb 9, 2018

jenkins test it

@tsg
Copy link
Contributor

tsg commented Feb 12, 2018

@perjahn This is close to being merged, if you want, we can either send you a PR to your branch after running make update, or take over the commits in a new PR.

@perjahn
Copy link
Contributor Author

perjahn commented Feb 13, 2018

Yes, please take over the commits.

ruflin pushed a commit to ruflin/beats that referenced this pull request Feb 27, 2018
@ruflin
Copy link
Member

ruflin commented Feb 27, 2018

I took the PR over here: #6479

@perjahn Thanks for your work on this one.

@ruflin ruflin closed this Feb 27, 2018
andrewkroh pushed a commit that referenced this pull request Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants