Fix metricbeat test util RunPushMetricSetV2 #6198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A test case could become deadlocked waiting to write to a channel. This would happen if the metricset under test attempted to publish events after the event consumer was stopped. Now when the metricset publishes to the stopped Reporter it will return false just as the real Reporter does in Metricbeat. I also identified a resource leak while stress testing Auditbeat on Windows. The file_integrity module's fsnotify reader was not being closed when the done channel was closed. This would only affect Windows/Linux users that were constantly reloading their file_integrity config with config reloading.
|
@ruflin This should fix the |
|
@andrewkroh I wonder if we should backport this to 6.2 even though it probably only happens in edge cases? |
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Jan 29, 2018
A test case could become deadlocked waiting to write to a channel. This would happen if the metricset under test attempted to publish events after the event consumer was stopped. Now when the metricset publishes to the stopped Reporter it will return false just as the real Reporter does in Metricbeat. I also identified a resource leak while stress testing Auditbeat on Windows. The file_integrity module's fsnotify reader was not being closed when the done channel was closed. This would only affect Windows/Linux users that were constantly reloading their file_integrity config with config reloading. (cherry picked from commit fe5df41)
exekias
pushed a commit
that referenced
this pull request
Jan 29, 2018
A test case could become deadlocked waiting to write to a channel. This would happen if the metricset under test attempted to publish events after the event consumer was stopped. Now when the metricset publishes to the stopped Reporter it will return false just as the real Reporter does in Metricbeat. I also identified a resource leak while stress testing Auditbeat on Windows. The file_integrity module's fsnotify reader was not being closed when the done channel was closed. This would only affect Windows/Linux users that were constantly reloading their file_integrity config with config reloading. (cherry picked from commit fe5df41)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
) A test case could become deadlocked waiting to write to a channel. This would happen if the metricset under test attempted to publish events after the event consumer was stopped. Now when the metricset publishes to the stopped Reporter it will return false just as the real Reporter does in Metricbeat. I also identified a resource leak while stress testing Auditbeat on Windows. The file_integrity module's fsnotify reader was not being closed when the done channel was closed. This would only affect Windows/Linux users that were constantly reloading their file_integrity config with config reloading. (cherry picked from commit b84cc51)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test case could become deadlocked waiting to write to a channel. This would happen if the metricset under test attempted to publish events after the event consumer was stopped. Now when the metricset publishes to the stopped Reporter it will return false just as the real Reporter does in Metricbeat.
I also identified a resource leak while stress testing Auditbeat on Windows. The file_integrity module's fsnotify reader was not being closed when the done channel was closed. This would only affect Windows/Linux users that were constantly reloading their file_integrity config with config reloading.