Add Windows service dashboard #5603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
force-pushed
the
feature/mb/windows-service-dashboard
branch
from
79c5634
to
9b08647
Compare
- Renamed the enums for the `start_state` and `state` fields to make them more readable and familiar to services.msc users. - Added `id`, `pid`, and `exit_code` to the data reported by the metricset. The `windows.service.id` field was added to make dashboarding easier. It removes the need to have a scripted field providing a composite of the `beat.name` and the `windows.service.name` to uniquely identify a service. - Added a dashboard that shows an overview of the services.
andrewkroh
force-pushed
the
feature/mb/windows-service-dashboard
branch
from
9b08647
to
76f9a15
Compare
ruflin
approved these changes
Nov 16, 2017
| - name: pid | ||
| type: long | ||
| example: 1092 |
There was a problem hiding this comment.
Do we have example support (yet) in this fields.yml here? :-)
| @@ -11535,15 +11539,43 @@ The display name of the service. | |||
|
|
|||
| type: keyword | |||
|
|
|||
| The start type of the service. The possible values are `ServiceAutoStart`, `ServiceBootStart`, `ServiceDemandStart`, `ServiceDisabled`, and `ServiceSystemStart`. | |||
| The startup type of the service. The possible values are `Automatic`, `Boot`, `Disabled`, `Manual`, and `System`. | |||
There was a problem hiding this comment.
This is kind of a breaking change. Should we mention that under Breaking changes?
|
Merged anyways, we can still do a follow up PR for the CHANGELOG entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
start_stateandstatefields to make them more readable and familiar to services.msc users.id,pid, andexit_codeto the data reported by the metricset. Thewindows.service.idfield was added to make dashboarding easier. It removes the need to have a scripted field providing a composite of thebeat.nameand thewindows.service.nameto uniquely identify a service.