Remove hard-coded namespace from k8s config #5482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
exekias
reviewed
Oct 31, 2017
| return kubeAnnotatorConfig{ | ||
| InCluster: true, | ||
| SyncPeriod: 1 * time.Second, | ||
| CleanupTimeout: 60 * time.Second, | ||
| Namespace: "kube-system", |
There was a problem hiding this comment.
I think it's best if we remove Namespace field from kubeAnnotatorConfig, and move all references to client.Namespace
There was a problem hiding this comment.
Yeah, I considered doing that initially as well. Will adjust now!
|
jenkins, test it please |
|
Can one of the admins verify this patch? |
The default namespace should be populated by the Kubernetes client. In the case of in-cluster config, the namespace will be read from the /var/run/secrets/kubernetes.io/serviceaccount/namespace file. (Note that this assumes the ServiceAccount admission controller is in use.) In the case of parsing a k8s configuration file, the default namespace is set to the client default of "default". Minor spelling correction of Kubernetes and some additional error information was changed as well. Closes elastic#5378
jpeeler
force-pushed
the
k8s-default-namespace
branch
from
357df18
to
e20beda
Compare
andrewkroh
approved these changes
Nov 2, 2017
|
Just gave this a try, works for me, thank you 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit text for more details. I haven't actually tested this yet, but looking at the client code I can't see how this would fail in any previously working scenario. @tarasglek care to verify all is well now?
(#5378)