Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cms_get and cmd_set mixed up in memcached module #5189

Merged
merged 1 commit into from
Sep 25, 2017

Conversation

dariusj18
Copy link
Contributor

@elasticmachine
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Contributor

@tsg tsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for noticing that! Can you add a line to the CHANGELOG, under Bug Fixes please? Something like Fixed cmd_set/cmd_get being mixed up in the memcached module {pull}5189[5189]

@tsg
Copy link
Contributor

tsg commented Sep 25, 2017

Merging, will add changelog in a new PR.

@tsg tsg merged commit f1bc714 into elastic:master Sep 25, 2017
@tsg tsg added the needs_backport PR is waiting to be backported to other branches. label Sep 25, 2017
tsg added a commit to tsg/beats that referenced this pull request Sep 25, 2017
ruflin pushed a commit that referenced this pull request Sep 25, 2017
tsg pushed a commit to tsg/beats that referenced this pull request Sep 25, 2017
tsg added a commit to tsg/beats that referenced this pull request Sep 25, 2017
@tsg tsg removed the needs_backport PR is waiting to be backported to other branches. label Sep 25, 2017
ruflin pushed a commit that referenced this pull request Sep 25, 2017
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants