Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @metadata.version to json events #5166

Merged
merged 5 commits into from
Sep 12, 2017

Conversation

urso
Copy link

@urso urso commented Sep 12, 2017

No description provided.

urso added 2 commits September 12, 2017 16:31
- pass beat.Info into the codecs
- update json encoder to include @metadata.version (for Console, File, Logstash, Redis, Kafka)
@urso urso added needs_backport PR is waiting to be backported to other branches. review labels Sep 12, 2017
document_type => "%{[@metadata][type]}" <2>
}
}
------------------------------------------------------------------------------
<1> `%{[@metadata][beat]}` sets the first part of the index name to the value
of the `beat` metadata field, and `%{+YYYY.MM.dd}` sets the second part of the
of the `beat` metadata field, `%{[@metadata][version]}` sets the second part of
the name to the beat's version, and `%{+YYYY.MM.dd}` sets the second part of the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/second/third/?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@tsg
Copy link
Contributor

tsg commented Sep 12, 2017

Looks like there are still test failures on this one.

@andrewkroh andrewkroh merged commit 46dbdbd into elastic:master Sep 12, 2017
@urso urso removed the needs_backport PR is waiting to be backported to other branches. label Sep 12, 2017
urso pushed a commit to urso/beats that referenced this pull request Sep 12, 2017
* Add @metadata.version to json events

- pass beat.Info into the codecs
- update json encoder to include @metadata.version (for Console, File, Logstash, Redis, Kafka)

* Update Ls docs to use the version field

* Fix test build

* s/second/third/

* Fix metricbeat unit tests

(cherry picked from commit 46dbdbd)
andrewkroh pushed a commit that referenced this pull request Sep 12, 2017
* Add @metadata.version to json events

- pass beat.Info into the codecs
- update json encoder to include @metadata.version (for Console, File, Logstash, Redis, Kafka)

* Update Ls docs to use the version field

* Fix test build

* s/second/third/

* Fix metricbeat unit tests

(cherry picked from commit 46dbdbd)
@urso urso deleted the event/send-version-in-meta branch February 19, 2019 18:32
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
* Add @metadata.version to json events

- pass beat.Info into the codecs
- update json encoder to include @metadata.version (for Console, File, Logstash, Redis, Kafka)

* Update Ls docs to use the version field

* Fix test build

* s/second/third/

* Fix metricbeat unit tests

(cherry picked from commit 11e8513)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants