Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing MongoDB config from the modules.d folder #4870

Merged
merged 1 commit into from
Aug 11, 2017

Conversation

tsg
Copy link
Contributor

@tsg tsg commented Aug 11, 2017

The command that collected the configurations, used something like
this to list the modules:

ls module | grep -v .go

Problem was, mongodb matched the .go grep, so it was excluded :)

This PR uses find to list the directories.

@tsg tsg added Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. review v6.0.0-beta2 labels Aug 11, 2017
The command that collected the configurations, used something like
this to list the modules:

   ls module | grep -v .go

Problem was, `mongodb` matched the `.go` grep, so it was excluded :)

This PR uses `find` to list the directories.
@tsg tsg force-pushed the fix_missing_mongodb_config branch from 8d4f6e0 to 919f1ca Compare August 11, 2017 07:24
Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFG

@exekias exekias merged commit 5adf7e1 into elastic:master Aug 11, 2017
exekias pushed a commit to exekias/beats that referenced this pull request Aug 16, 2017
The command that collected the configurations, used something like
this to list the modules:

   ls module | grep -v .go

Problem was, `mongodb` matched the `.go` grep, so it was excluded :)

This PR uses `find` to list the directories.
exekias pushed a commit to exekias/beats that referenced this pull request Aug 16, 2017
The command that collected the configurations, used something like
this to list the modules:

   ls module | grep -v .go

Problem was, `mongodb` matched the `.go` grep, so it was excluded :)

This PR uses `find` to list the directories.
(cherry picked from commit 5adf7e1)
@exekias exekias removed the needs_backport PR is waiting to be backported to other branches. label Aug 16, 2017
andrewkroh pushed a commit that referenced this pull request Aug 16, 2017
…s.d` folder (#4925)

* Fix missing MongoDB config from the `modules.d` folder (#4870)

The command that collected the configurations, used something like
this to list the modules:

   ls module | grep -v .go

Problem was, `mongodb` matched the `.go` grep, so it was excluded :)

This PR uses `find` to list the directories.

(cherry picked from commit 5adf7e1)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…`modules.d` folder (elastic#4925)

* Fix missing MongoDB config from the `modules.d` folder (elastic#4870)

The command that collected the configurations, used something like
this to list the modules:

   ls module | grep -v .go

Problem was, `mongodb` matched the `.go` grep, so it was excluded :)

This PR uses `find` to list the directories.

(cherry picked from commit 437273d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants