Fallback on LevelRaw If the Level is not in the RenderingInfo section of the event #4257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck on the raw level. Applies to Windows Vista and above only. https://discuss.elastic.co/t/event-fields-missing-if-renderinginfo-is-empty/84709
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
1 similar comment
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
andrewkroh
reviewed
May 9, 2017
winlogbeat/eventlog/wineventlog.go
Outdated
| @@ -216,6 +217,11 @@ func (l *winEventLog) buildRecordFromXML(x []byte, recoveredErr error) (Record, | |||
| e.RenderErr = recoveredErr.Error() | |||
| } | |||
|
|
|||
| if e.Level == "" { | |||
| //Let's fallback on LevelRaw if the level is not set in the RenderingInfo | |||
There was a problem hiding this comment.
Could you please change this to
// Fallback on LevelRaw if the Level is not set in the RenderingInfo.
winlogbeat/eventlog/wineventlog.go
Outdated
| @@ -11,6 +11,7 @@ import ( | |||
| "github.com/elastic/beats/libbeat/common" | |||
| "github.com/elastic/beats/libbeat/logp" | |||
| "github.com/elastic/beats/winlogbeat/sys" | |||
| "github.com/elastic/beats/winlogbeat/sys/wineventlog" | |||
There was a problem hiding this comment.
For consistency, could you use the "aliased" import below for this package. It's just aliased to win.
andrewkroh
approved these changes
May 9, 2017
andrewkroh
pushed a commit
to andrewkroh/beats
that referenced
this pull request
Jul 19, 2017
…event (elastic#4257) If the Level is not in the RenderingInfo section of the event, fallback on the raw level. Applies to Windows Vista and above only. https://discuss.elastic.co/t/event-fields-missing-if-renderinginfo-is-empty/84709 (cherry picked from commit c18adce)
andrewkroh
removed
the
needs_backport
andrewkroh
pushed a commit
to andrewkroh/beats
that referenced
this pull request
Jul 19, 2017
…event (elastic#4257) If the Level is not in the RenderingInfo section of the event, fallback on the raw level. Applies to Windows Vista and above only. https://discuss.elastic.co/t/event-fields-missing-if-renderinginfo-is-empty/84709 (cherry picked from commit c18adce)
andrewkroh
pushed a commit
to andrewkroh/beats
that referenced
this pull request
Jul 19, 2017
…event (elastic#4257) If the Level is not in the RenderingInfo section of the event, fallback on the raw level. Applies to Windows Vista and above only. https://discuss.elastic.co/t/event-fields-missing-if-renderinginfo-is-empty/84709 (cherry picked from commit c18adce)
tsg
pushed a commit
that referenced
this pull request
Jul 20, 2017
…event (#4257) (#4713) If the Level is not in the RenderingInfo section of the event, fallback on the raw level. Applies to Windows Vista and above only. https://discuss.elastic.co/t/event-fields-missing-if-renderinginfo-is-empty/84709 (cherry picked from commit c18adce)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies to Windows Vista and above only.
https://discuss.elastic.co/t/event-fields-missing-if-renderinginfo-is-empty/84709