Move elasticsearch node_stats metricset under node.stats namespace #4142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
reviewed
May 1, 2017
metricbeat/mb/module/event.go
Outdated
| @@ -68,37 +59,32 @@ func (b EventBuilder) Build() (common.MapStr, error) { | |||
| if n, ok := event["_namespace"]; ok { | |||
| delete(event, "_namespace") | |||
| namespace = n.(string) | |||
There was a problem hiding this comment.
Just to be safe, this should check the boolean that is returned that indicates the success of the type assertion.
metricbeat/mb/module/event.go
Outdated
| // In case meta data exists, it is added on the module level | ||
| // This is mostly used for shared fields across multiple metricsets in one module | ||
| if moudleDataExists { | ||
| if _, ok := moduleData.(common.MapStr); ok { |
There was a problem hiding this comment.
Instead of ignoring the result of the type assertion with an assignment to _, we could use the value in the following expression instead of doing a second type assertion.
ruflin
force-pushed
the
node.stats
branch
3 times, most recently
from
d4ed150
to
5ba5dad
Compare
So far the node_stats was putting all its data under `elasticsearch.node_stats.*`. This was changed to `elasticsearch.node.stats.*`. Further changes: * Remove support for setting index in metricset. This was never used and can now be done through using format string in the index setting. * Remove support for setting type in metricset. Type will be removed in elasticsearch. * Rename ModuleData constant to ModuleDataKey. * Introduce NamespaceKey as constant to replace hardcoded `_namespace`. * Cleanup event generation for metricbeat. * Remove `type` from event as not needed and remove it as required field.
|
jenkins, retest it |
andrewkroh
approved these changes
May 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far the node_stats was putting all its data under
elasticsearch.node_stats.*. This was changed toelasticsearch.node.stats.*.Further changes:
_namespace.typefrom event as not needed.