Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.15](backport #40870) [AWS CloudWatch Metrics] Record previous endTime to use for next collection period #40929

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 20, 2024

Proposed commit message

This PR is to record the previous endTime from the previous collection period to use for calculating the next collection start time and end time.
With using the previous endTime as the new startTime, we will not skip time range in collection.

This PR also changes log.logger from cloudwatch to aws.cloudwatch to match the other logger.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

N/A. User will see no gap in collection startTime and endTime, should be an enhancement.

How to test this PR locally

  1. Pull this PR and run mage build to build Metricbeat locally.
  2. ./metricbeat modules enable aws
  3. Configure in aws.yml:
- module: aws
  period: 5m
  metricsets:
    - cloudwatch
  include_linked_accounts: true
  metrics:
    - namespace: AWS/RDS
  1. Run metricbeat with debug log on
  2. Check metricbeat log to make sure startTime and endTime are connected for all collection periods.

This is an automatic backport of pull request #40870 done by [Mergify](https://mergify.com).

…ection period (#40870)

This PR is to record the previous endTime from the previous collection period to use for calculating the next collection start time and end time. This PR also changes log.logger from cloudwatch to aws.cloudwatch to match the other logger.

(cherry picked from commit cef78ed)
@mergify mergify bot requested a review from a team as a code owner September 20, 2024 18:36
@mergify mergify bot added the backport label Sep 20, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 20, 2024
@botelastic
Copy link

botelastic bot commented Sep 20, 2024

This pull request doesn't have a Team:<team> label.

@kaiyan-sheng kaiyan-sheng merged commit 3520bb4 into 8.15 Sep 20, 2024
18 of 20 checks passed
@kaiyan-sheng kaiyan-sheng deleted the mergify/bp/8.15/pr-40870 branch September 20, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant