Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS CloudWatch Metrics] Record previous endTime to use for next collection period #40870

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Sep 17, 2024

Proposed commit message

This PR is to record the previous endTime from the previous collection period to use for calculating the next collection start time and end time.
With using the previous endTime as the new startTime, we will not skip time range in collection.

This PR also changes log.logger from cloudwatch to aws.cloudwatch to match the other logger.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

N/A. User will see no gap in collection startTime and endTime, should be an enhancement.

How to test this PR locally

  1. Pull this PR and run mage build to build Metricbeat locally.
  2. ./metricbeat modules enable aws
  3. Configure in aws.yml:
- module: aws
  period: 5m
  metricsets:
    - cloudwatch
  include_linked_accounts: true
  metrics:
    - namespace: AWS/RDS
  1. Run metricbeat with debug log on
  2. Check metricbeat log to make sure startTime and endTime are connected for all collection periods.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 17, 2024
@kaiyan-sheng kaiyan-sheng self-assigned this Sep 17, 2024
Copy link
Contributor

mergify bot commented Sep 17, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kaiyan-sheng? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Sep 17, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 17, 2024
@kaiyan-sheng kaiyan-sheng marked this pull request as ready for review September 18, 2024 20:42
@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner September 18, 2024 20:42
@kaiyan-sheng kaiyan-sheng added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team label Sep 18, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 18, 2024
@kaiyan-sheng kaiyan-sheng added the backport-8.15 Automated backport to the 8.15 branch with mergify label Sep 19, 2024
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaiyan-sheng kaiyan-sheng merged commit cef78ed into elastic:main Sep 20, 2024
20 checks passed
@kaiyan-sheng kaiyan-sheng deleted the use_previous_endtime branch September 20, 2024 18:35
mergify bot pushed a commit that referenced this pull request Sep 20, 2024
…ection period (#40870)

This PR is to record the previous endTime from the previous collection period to use for calculating the next collection start time and end time. This PR also changes log.logger from cloudwatch to aws.cloudwatch to match the other logger.

(cherry picked from commit cef78ed)
mergify bot pushed a commit that referenced this pull request Sep 20, 2024
…ection period (#40870)

This PR is to record the previous endTime from the previous collection period to use for calculating the next collection start time and end time. This PR also changes log.logger from cloudwatch to aws.cloudwatch to match the other logger.

(cherry picked from commit cef78ed)
kaiyan-sheng added a commit that referenced this pull request Sep 20, 2024
…ection period (#40870) (#40929)

This PR is to record the previous endTime from the previous collection period to use for calculating the next collection start time and end time. This PR also changes log.logger from cloudwatch to aws.cloudwatch to match the other logger.

(cherry picked from commit cef78ed)

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
kaiyan-sheng added a commit that referenced this pull request Sep 20, 2024
…ection period (#40870) (#40930)

This PR is to record the previous endTime from the previous collection period to use for calculating the next collection start time and end time. This PR also changes log.logger from cloudwatch to aws.cloudwatch to match the other logger.

(cherry picked from commit cef78ed)

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.15 Automated backport to the 8.15 branch with mergify Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants