Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updatecli: set username #40527

Merged
merged 1 commit into from
Aug 15, 2024
Merged

updatecli: set username #40527

merged 1 commit into from
Aug 15, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Aug 14, 2024

Proposed commit message

Fix updatecli when accessing the repositories since the username is required now.

Similarly resolved in elastic/golang-crossbuild#429

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@v1v v1v added backport-7.17 Automated backport to the 7.17 branch with mergify backport-8.15 Automated backport to the 8.15 branch with mergify labels Aug 14, 2024
@v1v v1v self-assigned this Aug 14, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 14, 2024
@botelastic
Copy link

botelastic bot commented Aug 14, 2024

This pull request doesn't have a Team:<team> label.

@v1v
Copy link
Member Author

v1v commented Aug 14, 2024 •
edited
Loading

Tests:

If they work then we can merge this PR

@v1v v1v marked this pull request as ready for review August 14, 2024 18:30
@v1v v1v requested a review from a team as a code owner August 14, 2024 18:30
@v1v v1v enabled auto-merge (squash) August 15, 2024 07:50
@v1v v1v merged commit 11e71e0 into main Aug 15, 2024
15 checks passed
@v1v v1v deleted the fix/updatecli-authentication branch August 15, 2024 10:56
mergify bot pushed a commit that referenced this pull request Aug 15, 2024
@v1v @mergify
updatecli: set username (#40527)
7308d24 
(cherry picked from commit 11e71e0)
@mergify mergify bot mentioned this pull request Aug 15, 2024
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Aug 15, 2024
@v1v @mergify
updatecli: set username (#40527)
b5706cf 
(cherry picked from commit 11e71e0)
@mergify mergify bot mentioned this pull request Aug 15, 2024
Merged
6 tasks
v1v pushed a commit that referenced this pull request Aug 15, 2024
@mergify
[7.17](backport #40527) updatecli: set username (#40533)
9330fab
v1v added a commit that referenced this pull request Aug 15, 2024
@mergify @v1v
[8.15](backport #40527) updatecli: set username (#40534)
c8020d9 
(cherry picked from commit 11e71e0)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pazone pazone pazone approved these changes

@cmacknz cmacknz cmacknz approved these changes

@craig-abbott craig-abbott Awaiting requested review from craig-abbott

Assignees

@v1v v1v

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-8.15 Automated backport to the 8.15 branch with mergify needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v1v @pazone @cmacknz