-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: consistently use one uuid library #40161
Merged
Merged
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
a88bcb4
refactor: consistently use one uuid library
kruskall e8c21b5
lint: fix linting issues
kruskall aa7304f
Merge branch 'main' into feat/standard-uuid-lib
kruskall 0fee800
refactor: move to gofrs/uuid
kruskall fb77a5a
lint: add gomodguard setting
kruskall 74beaf9
lint: fix more linter issues
kruskall 3e40b83
lint: more linting errors
kruskall 7772b15
lint: completely remove gofrs/uuid v4
kruskall f500379
lint: more linting errors
kruskall ec7de41
lint: more linting errors
kruskall 29af9f1
Merge branch 'main' into feat/standard-uuid-lib
kruskall 9eaa809
lint: fix more linting errors
kruskall f3ecc1f
fix: replace uuid.MustParse with uuid.Must(uuid.FromString())
kruskall 9e33175
refactor: update uuid.Parse to uuid.FromString
kruskall 9096808
lint: fix linting errors
kruskall 1c17360
lint: fix linting errors
kruskall d6d7ee3
docs: fix nolint comments
kruskall bd1db14
lint: fix linting errors
kruskall 4ed1ee3
docs: update nolint comments
kruskall 8acb07e
Merge branch 'main' into feat/standard-uuid-lib
kruskall 25cf98a
test: update uuid parsing err
kruskall 1b9e4c3
Merge branch 'main' into feat/standard-uuid-lib
kruskall 46615a1
Merge branch 'main' into feat/standard-uuid-lib
kruskall b16de08
Merge branch 'main' into feat/standard-uuid-lib
kruskall bc7f278
lint: fix linter issues
kruskall 9436142
lint: fix linter issues
kruskall ce1af44
Merge branch 'main' into feat/standard-uuid-lib
kruskall 736b471
Merge branch 'main' into feat/standard-uuid-lib
kruskall 6f0ebeb
Merge branch 'main' into feat/standard-uuid-lib
kruskall ce59b70
Merge branch 'main' into feat/standard-uuid-lib
kruskall 055c223
lint: run go mod tidy
kruskall 56b0e58
lint: regenerate notice
kruskall 66555cb
Merge branch 'main' into feat/standard-uuid-lib
kruskall b523946
Merge branch 'main' into feat/standard-uuid-lib
kruskall 1b62afd
Merge branch 'main' into feat/standard-uuid-lib
kruskall cafe665
Merge branch 'main' into feat/standard-uuid-lib
kruskall 2d7a8c1
Merge remote-tracking branch 'upstream/main' into feat/standard-uuid-lib
kruskall cd282a6
build: regenerate notice
kruskall bade374
Merge branch 'main' into feat/standard-uuid-lib
kruskall cbe3070
Merge branch 'main' into feat/standard-uuid-lib
kruskall 9047bf0
Merge branch 'main' into feat/standard-uuid-lib
kruskall 8454631
Merge remote-tracking branch 'upstream/main' into feat/standard-uuid-lib
kruskall 2302448
build: regenerate notice
kruskall aa74525
refactor: cleanup double uuid conversion
kruskall 4602e5d
Merge branch 'main' into feat/standard-uuid-lib
kruskall 05cbada
Merge branch 'main' into feat/standard-uuid-lib
kruskall 46694a3
Merge branch 'main' into feat/standard-uuid-lib
kruskall e4cdd74
Merge branch 'main' into feat/standard-uuid-lib
kruskall e7566f1
Merge branch 'main' into feat/standard-uuid-lib
kruskall 4c5cf4c
test: gracefully log the error
kruskall cad2258
Merge branch 'main' into feat/standard-uuid-lib
kruskall 285779f
Merge branch 'main' into feat/standard-uuid-lib
kruskall File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any cases that these error values are returned wrapped so (disclaimer: as a non-owner) I'm not convinced of the value of this, but if this change is going to be made, the tests that look at error values should be updated to match (
ErrInactive
is the target of an exact value check).