-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MODULE definition for x-pack/dockerlogbeat Go Integration tests #39235
Conversation
73c1a26
to
1549ad5
Compare
1549ad5
to
2ba8f09
Compare
39eda9e
to
8a7b899
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically LGTM; I've left a few comments to lowercase Dockerlogbeat
reflecting the name (and helping GH keep the status checks properly sorted).
9fd5c16
to
23c19d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
left a small ask to change the name of the main packaging step to "Packaging" because it is packaging everything apart from Linux ARM.
23c19d0
to
6a6ec63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6a6ec63
to
8ff67fe
Compare
8ff67fe
to
8e35975
Compare
…39235) (#39457) * added MODULE env var definition * removed MODULE setup from common.sh * updated pipeline and scripts * pr fixes * removed pipeline masking where irrelevant * updated packaging step & gh notif names (cherry picked from commit b6b4280) Co-authored-by: Olga Naydyonock <olga.naidjonoka@elastic.co>
…39235) (#39458) * added MODULE env var definition * removed MODULE setup from common.sh * updated pipeline and scripts * pr fixes * removed pipeline masking where irrelevant * updated packaging step & gh notif names (cherry picked from commit b6b4280) Co-authored-by: Olga Naydyonock <olga.naidjonoka@elastic.co>
…39235) (#39459) * added MODULE env var definition * removed MODULE setup from common.sh * updated pipeline and scripts * pr fixes * removed pipeline masking where irrelevant * updated packaging step & gh notif names (cherry picked from commit b6b4280) Co-authored-by: Olga Naydyonock <olga.naidjonoka@elastic.co>
Proposed commit message
In scope of https://github.com/elastic/ingest-dev/issues/3254 - added MODULE env var definition for Go Integration tests to match same behavior as on Jenkins.
Jenkins vs. Buildkite comparison: https://gist.github.com/oakrizan/bf2aa5f1cd1ab01daa1184f471a99abc
BK build: https://buildkite.com/elastic/beats-xpack-dockerlogbeat/builds?branch=oakrizan%3Axpack-dockerlogbeat-fixes
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs