Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auditbeat - skip TestExeObjParser on CI #38441

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Mar 19, 2024

Proposed commit message

TestExeObjParser fails on Windows because Defender is removing the testdata that is required by the test. This adds a conditional test skip for CI when those files are missing.

Closes #38211

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

TestExeObjParser fails on Windows because Defender is removing the
testdata that is required by the test. This adds a conditional test
skip for CI when those files are missing.

Closes elastic#38211
@andrewkroh andrewkroh added Auditbeat flaky-test Unstable or unreliable test cases. Team:Security-Linux Platform Linux Platform Team in Security Solution labels Mar 19, 2024
@andrewkroh andrewkroh requested a review from a team as a code owner March 19, 2024 19:06
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 19, 2024
Copy link
Contributor

mergify bot commented Mar 19, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @andrewkroh? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@andrewkroh andrewkroh enabled auto-merge (squash) March 19, 2024 19:08
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @andrewkroh

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @andrewkroh

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @andrewkroh

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @andrewkroh

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @andrewkroh

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @andrewkroh

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @andrewkroh

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @andrewkroh

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 19, 2024

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 19, 2024

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 47 min 3 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@andrewkroh andrewkroh merged commit 08e5936 into elastic:main Mar 19, 2024
43 of 47 checks passed
@pierrehilbert pierrehilbert added backport-v8.12.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify labels Mar 20, 2024
mergify bot pushed a commit that referenced this pull request Mar 20, 2024
TestExeObjParser fails on Windows because Defender is removing the
testdata that is required by the test. This adds a conditional test
skip for CI when those files are missing.

Closes #38211

(cherry picked from commit 08e5936)
mergify bot pushed a commit that referenced this pull request Mar 20, 2024
TestExeObjParser fails on Windows because Defender is removing the
testdata that is required by the test. This adds a conditional test
skip for CI when those files are missing.

Closes #38211

(cherry picked from commit 08e5936)
pierrehilbert pushed a commit that referenced this pull request Mar 20, 2024
TestExeObjParser fails on Windows because Defender is removing the
testdata that is required by the test. This adds a conditional test
skip for CI when those files are missing.

Closes #38211

(cherry picked from commit 08e5936)

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
pierrehilbert pushed a commit that referenced this pull request Mar 20, 2024
TestExeObjParser fails on Windows because Defender is removing the
testdata that is required by the test. This adds a conditional test
skip for CI when those files are missing.

Closes #38211

(cherry picked from commit 08e5936)

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
@pierrehilbert
Copy link
Collaborator

I added some backports as it was failing on the other branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auditbeat backport-v8.12.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify flaky-test Unstable or unreliable test cases. Team:Security-Linux Platform Linux Platform Team in Security Solution
Projects
None yet
5 participants